Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle 403 errors for 1inch requests #96

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Handle 403 errors for 1inch requests #96

merged 1 commit into from
Dec 20, 2024

Conversation

squadgazzz
Copy link
Contributor

@squadgazzz squadgazzz commented Dec 18, 2024 •
edited
Loading

From the original issue #95:

The 1Inch API requires you to tell them which address wants to do the trade. Due to legal requirements they do not serve some addresses. In those cases the API call will return a 403 error.
Currently these get forwarded to the driver in a way that causes alerts like this although they are to be expected and don't indicate an error in the 1Inch API.

All the 403 errors are considered NotFound to reduce false alerts.

Fixes #95

@squadgazzz squadgazzz marked this pull request as ready for review December 18, 2024 17:58
@ahhda ahhda requested a review from MartinquaXD December 19, 2024 06:04
ahhda
ahhda approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@ahhda ahhda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@squadgazzz squadgazzz merged commit ec9a318 into main Dec 20, 2024
3 checks passed
@squadgazzz squadgazzz deleted the fix/95 branch December 20, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinquaXD MartinquaXD MartinquaXD approved these changes

@ahhda ahhda ahhda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle 403 errors for 1inch requests
3 participants
@squadgazzz @ahhda @MartinquaXD